CODEWITHSUNDEEP
javascriptajaxfunction
Mark Lyons
Mark Lyons

Reputation: 1422

Javascript if statement not working as intended

If you look here and try to click on the voting arrows, you'll see my problem. Now compare that to the homepage (click logo). Try voting there. The arrows change image based on vote. I also use a in_array() function to determine what the user has voted on and it produces the correct voting icon. This all works fine on the submission page I linked to. However, again, if you try clicking on the links, it always defaults to the else statement in this Javascript function:

I'll only show the function for liking, as I'm having the identical problem for the dislike.

function getVote(filename, num, idnum, user)
  {
    var like = document.getElementById('like_arrow' + num);
    var dislike = document.getElementById('dislike_arrow' + num);

  if (like.src.indexOf('../vote_triangle.png')!=-1 && dislike.src.indexOf('../vote_triangle_flip.png')!=-1) {
   like.src = '../vote_triangle_like.png';

         (AJAX to alter rating here)

  } else if (like.src.indexOf('../vote_triangle.png') != -1) {
   like.src = '../vote_triangle_like.png';
   dislike.src = '../vote_triangle_flip.png';

         (AJAX to alter rating here)

  } else {
   like.src = '../vote_triangle.png'; // Always defaults to this

         (AJAX to alter rating here)

  }

}

In case you're wondering, the num variable is what I use on the front page to differentiate between the submissions, they increment by one for each one. In this though, I just made that value blank in the function so it shouldn't affect anything. Might be my problem though, but I can't see how.

Thanks!

Upvotes: 1

Views: 95

Answers (1)

BNL
BNL

Reputation: 7133

like.src isn't going to contain ..\. It may be as simple as removing that part.

Upvotes: 2

Related Questions