CODEWITHSUNDEEP
androidxmltextview
Jack Trowbridge
Jack Trowbridge

Reputation: 3251

android changing text view (is this code ok?)

Can some one help me, I have heard alot of things and I dont know what to believe. I am making an app that is a counter. In my xml layout i have a TextView acting as a counter and the text is set by a string in strings.xml and i am controlling what the text view says from my java file. here is some code snip its. all I want to know is this ok?, it works fine but I want to know is it a bad or good way.

"counter" equals a variable.
"display" is referencing the ID of the textview"

what i am using to control the text view.
display.setText(String.valueOf(counter)); 

here is my text view in my xml layout
<TextView
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:id="@+id/tvDisplay"
    android:gravity="center"
    android:text="@string/counter"
    android:textSize="20dp" />

here is the string in strings.xml
<string name="counter">0</string>

Upvotes: 2

Views: 405

Answers (2)

Shreyash Mahajan
Shreyash Mahajan

Reputation: 23606

Yes, All things are right and good. Yo should have to give the String Value as like that.

If there is a Small Value of TextView then you can directly give as android:text="abcd"

And If you want to give any reference of that then your code is also correct and works as well.

For the Best use of coading your should have to try as like you have done rightnow. as Because it helps you a lot if there are number of TextView and you want to manage or change the Value of it quickly.

Enjoy. :)

Thanks.

Upvotes: 1

Dave Newton
Dave Newton

Reputation: 160321

It's fine, that's how you change text dynamically.

Upvotes: 2

Related Questions