CODEWITHSUNDEEP
batch-file
Daniel Fortunov
Daniel Fortunov

Reputation: 44323

Batch file fails to set environment variable within conditional statement

Why does the following Windows Batch File output Foo followedby Bar, rather than Baz?

@echo off
setlocal

set _=Foo
echo %_%
set _=Bar
if 1==1 (
    set _=Baz
    echo %_%
)

The output on my system (Microsoft Windows XP [Version 5.1.2600]) is:

Foo
Bar

If I remove the conditional statement, the expected output of Foo and Baz is observed.

Upvotes: 14

Views: 9945

Answers (3)

paxdiablo
paxdiablo

Reputation: 881293

What's happening is that variable substitution is done when a line is read. What you're failing to take into account is the fact that:

if 1==1 (
    set _=Baz
    echo %_%
)

is one "line", despite what you may think. The expansion of "%_%" is done before the set statement.

What you need is delayed expansion. Just about every single one of my command scripts starts with "setlocal enableextensions enabledelayedexpansion" so as to use the full power of cmd.exe.

So my version of the script would be:

@echo off
setlocal enableextensions enabledelayedexpansion

set _=Foo
echo !_!
set _=Bar
if 1==1 (
    set _=Baz
    echo !_!
)

endlocal

This generates the correct "Foo", "Baz" rather than "Foo", "Bar".

Upvotes: 29

Nick Fortescue
Nick Fortescue

Reputation: 44153

The answer to this is the same as the answer to:Weird scope issue in batch file. See there for more details. Basically variable expansion is done at line read time, not at execution time.

Upvotes: 4

usman shaheen
usman shaheen

Reputation: 3766

try this

@echo off
setlocal

set _=Foo
echo %_%
set _=Bar
if "1" NEQ "2" goto end
set _=Baz
echo %_%
:end

Upvotes: 3

Related Questions