CODEWITHSUNDEEP
bashstring-comparison
moztech
moztech

Reputation: 430

Compare output rather than command

Trying to create a script to read a remote file and check the md5 checksum and alert if a mismatch yet getting an error I can't understand.

#!/bin/sh
REMOTEMD5=$(ssh user@host 'md5sum file.txt')
LOCALMD5=$(md5sum 'file.txt')
if [$LOCALMD5 !== $REMOTEMD5]
then
  echo "all OK"
else
  echo -e "no match, Local:"$LOCALMD5"\nRemote:"$REMOTEMD5
fi

This returns line 4: [6135222a12f06b2dfce6a5c1b736891e: command not found

I've tried using ' or " around the $LOCALMD5 but never seem able to get this to compare the outputs. What am I doing wrong? Thanks

Upvotes: 13

Views: 59259

Answers (3)

Kyle Jones
Kyle Jones

Reputation: 5532

[ isn't bash syntax, it is a command. So you must have a space between it and its first argument $LOCALMD5. There also needs to be a space between $REMOTEMD5 and ].

Upvotes: 7

Mithrandir
Mithrandir

Reputation: 25337

I think it should be like this:

#!/bin/sh
REMOTEMD5=$(ssh user@host 'md5sum file.txt')
LOCALMD5=$(md5sum 'file.txt')
if [ "$LOCALMD5" == "$REMOTEMD5" ]
then
  echo "all OK"
else
  echo -e "no match, Local:"$LOCALMD5"\nRemote:"$REMOTEMD5
fi

The space between the bracket and the value is important!

Upvotes: 10

Joachim Isaksson
Joachim Isaksson

Reputation: 180917

Try;

if [ "$LOCALMD5" == "$REMOTEMD5" ]

which should work better.

Edit: I think you got == and != reversed in your code.

Upvotes: 26

Related Questions