Reputation: 7659
I am trying to have a ProgressDialog appear when I am getting some data, in Activity. The activity runs normally, and the data are obtained, but the ProgressDialog does not appear.
private void updateData() {
ProgressDialog dialog = ProgressDialog.show(ParkActivity.this, "fvhnn", "A actualizar. Aguarde por favor...", true);
...
...
dialog.dismiss();
...
}
follow the code of my Activity.
public class ParkActivity extends Activity {
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
// Set View to register.xml
setContentView(R.layout.park);
SharedPreferences settings = getSharedPreferences(PREF_FILE, 0);
int ocupados = settings.getInt("ocupados", -1);
if(ocupados == -1) {
((TextView) findViewById(R.id.txtPercentageOcupation)).setVisibility(View.INVISIBLE);
((TextView) findViewById(R.id.txtLastUpdate)).setVisibility(View.INVISIBLE);
((TextView) findViewById(R.id.txtPlacesAvailable)).setVisibility(View.INVISIBLE);
((Button) findViewById(R.id.btnParkUpdate)).setVisibility(View.INVISIBLE);
updateData();
} else {
int total = settings.getInt("total", 440);
long data = settings.getLong("data", 0);
putData(ocupados, total, data);
}
Button btnUpdate = (Button) findViewById(R.id.btnParkUpdate);
btnUpdate.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View arg0) {
updateData();
}
});
}
private void updateData() {
ProgressDialog dialog = ProgressDialog.show(ParkActivity.this, "fvhnn", "A actualizar. Aguarde por favor...", true);
SharedPreferences settings = getSharedPreferences(PREF_FILE, 0);
String session = settings.getString("sessionID", "null");
int[] vagas = ISEP_Proxy.vagas(session);
Date dt = new Date();
putData(vagas[0], vagas[1], dt.getTime());
dialog.dismiss();
// save data
SharedPreferences.Editor editor = settings.edit();
editor.putInt("ocupados", vagas[0]);
editor.putInt("total", vagas[1]);
editor.putLong("data", dt.getTime());
editor.commit();
}
private void putData(int ocupados, int total, long date) {
String placesFormat = getResources().getString(R.string.PLACES_AVAILABLE);
String percentageFormat = getResources().getString(R.string.PERCENTAGE_OCUPATION);
String lastUpdate = getResources().getString(R.string.LAST_UPDATE);
double percentage = 100.0 * ocupados / total;
SimpleDateFormat df = new SimpleDateFormat("HH'h'mm 'de' dd-MM-yyyy");
((TextView) findViewById(R.id.txtPercentageOcupation)).setVisibility(View.VISIBLE);
((TextView) findViewById(R.id.txtLastUpdate)).setVisibility(View.VISIBLE);
((TextView) findViewById(R.id.txtPlacesAvailable)).setVisibility(View.VISIBLE);
((Button) findViewById(R.id.btnParkUpdate)).setVisibility(View.VISIBLE);
((TextView) findViewById(R.id.txtPercentageOcupation)).setText(String.format(percentageFormat, ((int) percentage) + "%"));
((TextView) findViewById(R.id.txtPlacesAvailable)).setText(String.format(placesFormat, total - ocupados));
((TextView) findViewById(R.id.txtLastUpdate)).setText(String.format(lastUpdate, df.format(date)));
}
}
Anyone know what the problem is?
EDIT
@Ted Hopp Suggest to use a AsyncTask. I created the class GetISEPData and placed inside the dialog, but now the app gives me an error and closes.
private class GetISEPData extends AsyncTask<Void, Void, Void> {
Context cx;
ProgressDialog dialog;
public GetISEPData (Context context) {
cx = context;
}
@Override
protected Void doInBackground(Void... params) {
SharedPreferences settings = getSharedPreferences(PREF_FILE, 0);
String session = settings.getString("sessionID", "null");
int[] vagas = ISEP_Proxy.vagas(session);
Date dt = new Date();
putData(vagas[0], vagas[1], dt.getTime());
// save data
SharedPreferences.Editor editor = settings.edit();
editor.putInt("ocupados", vagas[0]);
editor.putInt("total", vagas[1]);
editor.putLong("data", dt.getTime());
editor.commit();
return null;
}
@Override
protected void onPostExecute(Void result) {
super.onPostExecute(result);
dialog = ProgressDialog.show(ParkActivity.this, "", "A actualizar. Aguarde por favor...", true);
}
@Override
protected void onPreExecute() {
// TODO Auto-generated method stub
super.onPreExecute();
dialog.dismiss();
}
}
for invoke put this:
Button btnUpdate = (Button) findViewById(R.id.btnParkUpdate);
btnUpdate.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View arg0) {
new GetISEPData(ParkActivity.this).execute();
}
});
Upvotes: 0
Views: 1121
Reputation: 234795
In between the call to show()
and the call to dismiss()
, you need to do the work in a separate thread. Until you return control to the framework, the dialog doesn't have a chance to get drawn. Take a look at AsyncTask for an easy way to do this.
EDIT: In your updated version of your code, you have the logic for onPreExecute and onPostExecute reversed -- you are trying to dismiss the dialog before it is shown!
Upvotes: 3
Reputation: 24423
I think it shown, but it also dismissed immediately cause the show() and dismiss() methods are placed in same thread.
Upvotes: 1