CODEWITHSUNDEEP
asp.net-mvcsession
Chris Arnold
Chris Arnold

Reputation: 5753

Session null in ASP.Net MVC Controller Constructors

Why is Session null in the constructors of Controllers? It can be accessed from Action methods. Presumably, because the MVC Routing framework is responsible for newing-up a Controller, it just hasn't (re-)instantiated the Session at that point.

Does anyone know if this is by design and, if so, why?

[I have managed to circumvent the problem by using a Lazy Loading Pattern.]

Upvotes: 91

Views: 70382

Answers (6)

Prashanth vunnam gcs
Prashanth vunnam gcs

Reputation: 270

This answer might be useful for some people

If we override Initialize method then we have to initialize base class with request context : base.Initialize(requestContext);

protected override void Initialize(RequestContext requestContext)
        {
            base.Initialize(requestContext);
           

        }

Upvotes: 2

VahidN
VahidN

Reputation: 19176

If you are using an IoC Container, try injecting and using the HttpSessionStateBase instead of the Session object:

private static Container defaultContainer()
{
    return new Container(ioc =>
    {
        // session manager setup
        ioc.For<HttpSessionStateBase>()
           .Use(ctx => new HttpSessionStateWrapper(HttpContext.Current.Session)); 
    });
}

Upvotes: 2

Funlover
Funlover

Reputation: 81

You can override the Initialize method to set your session.

protected override void Initialize(RequestContext requestContext)

Upvotes: 8

Mike Chamberlain
Mike Chamberlain

Reputation: 42520

In addition to the other answers here, while Controller.Session is not populated in the constructor, you can still access the session through:

System.Web.HttpContext.Current.Session

with the standard caveat that this potentially reduces your controller's testability.

Upvotes: 66

Andrew W
Andrew W

Reputation: 854

Andrei is right - it is null because when running under the ASP.NET MVC framework, the HttpContext (and therefore HttpContext.Session) is not set when the controller class is contructed as you might expect, but it set ("injected") later by the ControllerBuilder class. If you want a better understanding of the lifecycle you can either pull down the ASP.NET MVC framework (the source is available), or refer to: this page

If you need to access the Session then one way would be to override the "OnActionExecuting" method and access it there, as it will be available by that time.

However, as Andrei is suggesting, if your code is reliant on the Session then it could potentially be difficult to write unit tests, so perhaps you could consider wrapping the Session in a helper class which can then be swapped out for a different, non-web version when running under unit tests, therefore de-coupling your controller from the web.

Upvotes: 82

Andrei R&#238;nea
Andrei R&#238;nea

Reputation: 20800

The Session is injected later in the life-cycle. Why do you need the session in the constructor anyway? If you need it for TDD you should wrap the session into a mockable object.

Upvotes: 11

Related Questions