CODEWITHSUNDEEP
objective-ccastingcompiler-errors
Ky -
Ky -

Reputation: 32143

Problems with multiplying in Obj-C

I am new to Objective-C, so excuse me if this inherently doesn't work in the language, but it seems like it should. What I want to do is calculate the thickness of a book object in inches. Here are the objects in the Book header file:

NSString *title, *author;
int *numPages;
/**
 * The thickness of any given page in the book, in inches (e.g. 20lb stock would be 0.0038)
 */
double *pageThickness;
bool *hasHardCover;

The idea is that I'll calculate the thickness of the book by adding (the product of the page thickness and the number of pages) with (the thickness of the book cover; a quarter inch if it's hard cover, of four times the page thickness if it's paperback). However, I get several errors with the following implementation:

63 -(int *)calculateWidthInInches
64 {
65  return (((double *)numPages) *
66          pageThickness) +
67  (hasHardCover ? 0.25 :
68   (pageThickness * 4.0));
69 }

Here are the errors:

/Users/student4/Downloads/LibraryOfBooks/Book.m:66: error: invalid operands to binary * (have 'double *' and 'double *')
/Users/student4/Downloads/LibraryOfBooks/Book.m:68: error: invalid operands to binary * (have 'double *' and 'double')
/Users/student4/Downloads/LibraryOfBooks/Book.m:69: warning: control reaches end of non-void function

I suspect that the last one was caused by failure to compile the return line. What have I done wrong with my calculateWidthInInches method?

Fix:

63 -(double)calculateWidthInInches
64 {
65  return ((*numPages) * *pageThickness) + (*hasHardCover ? 0.25 : (*pageThickness * 4.0));
66 }

Upvotes: 0

Views: 1065

Answers (3)

ZhangChn
ZhangChn

Reputation: 3184

The method returned a pointer to int, by definition:

-(int *)calculateWidthInInches

It should be:

-(int)calculateWidthInInches

Edit: Also, as @thg435 suggested, you may also be wrong with other ivars typed as pointer to primitive data types.

IMHO, you may also need to change all your int*, double* and bool* typed variables to int, double and bool types.

These are primitive data types supported by C. In practice, an Objective-C object should hold these values, not pointer to these values if the object instance owns these values from the perspective of logic.

Upvotes: 1

andrewdotnich
andrewdotnich

Reputation: 16804

All your variables are pointers, not values. The compiler is complaining that you're attempting to multiply pointers, an operation that doesn't make sense.

You need to dereference the pointers before multiplying in order to multiply the values, not the addresses of the values.

EDIT: Also, as Yuras points out, casting the pointers directly is not a great idea — dereference the pointer, then cast the value:

-(double)calculateWidthInInches
{
    return (((double)*numPages) *
            pageThickness) +
    (*hasHardCover ? 0.25 :
     (*pageThickness * 4.0)); 
}

Upvotes: 3

Yuras
Yuras

Reputation: 13876

double and double * are different types. Binary operator * accepts two doubles, but you are trying to multiply double*s, which is wrong. The same is with the return type.

You could "dereference" pointers (*pageThickness) * 4.0.

But it would be better to use double instead of double * everywhere.

Also, casting int* to double* is usually very bad idea ;)

NSString *title, *author;
int numPages;
double pageThickness;
bool hasHardCover;

and

-(int)calculateWidthInInches
{
    return (((double)numPages) *
            pageThickness) +
    (hasHardCover ? 0.25 :
     (pageThickness * 4.0));
}

Upvotes: 0

Related Questions