CODEWITHSUNDEEP
sqloptimizationjoinfirebirdfirebird2.1
Steve
Steve

Reputation: 2520

How can I optimize this query in Firebird 2.1?

I'm using Firebird 2.1 and I'd need some help optimizing this query: (maybe by replacing IN-s with JOINS or something to speed it up, as it is very slow)

SELECT ClientID, ClientType, ClientName 
FROM Clients 
WHERE 
    (
        AccessRights = 0 OR 
        OwnerUserID = :uid OR 
        (
            AccessRights = 2 AND 
            ClientID IN (SELECT ClientID 
                            FROM ClientRights 
                            WHERE UserID = :uid)
        )
    ) 
    AND ClientID IN (SELECT CC.ClientID 
                    FROM CaseClients CC 
                    WHERE CC.CaseID IN (SELECT DISTINCT CaseID 
                                        FROM TimeSheet 
                                        WHERE IsBilled = 0) 
                        AND CC.ClientToBill = 1 
                        AND (SELECT BillingType 
                                FROM Cases 
                                WHERE CaseID = CC.CaseID) = 2
    );

Thanks!

Upvotes: 3

Views: 327

Answers (4)

rstrelba
rstrelba

Reputation: 1954

SELECT ClientID, ClientType, ClientName FROM Clients 
WHERE 
(
    AccessRights = 0 OR 
    OwnerUserID = :uid OR 
    (
        AccessRights = 2 AND 
        EXISTS(SELECT * FROM ClientRights r WHERE r.UserID = :uid and r.ClientId=Clients.ClientID)
    )
) 
AND EXISTS(SELECT * 
                FROM CaseClients CC 
                WHERE 
                CC.ClientID=Clients.ClientID and
                   EXISTS(SELECT * FROM TimeSheet 
                          WHERE IsBilled = 0 and TimeSheet.CaseID=CC.CaseID) 
                    AND CC.ClientToBill = 1 
                    AND EXISTS(SELECT BillingType 
                            FROM Cases 
                            WHERE CaseID = CC.CaseID and BillingType=2)
);

Upvotes: 1

Sagi
Sagi

Reputation: 1009

In My opinion this would be neater and faster:

SELECT  ClientID, ClientType, ClientName 
FROM    Clients C, CaseClients CC, TimeSheet TS, Cases CA
WHERE   C.ClientID = CC.ClientID 
AND CC.CaseID = TS.CaseID 
AND CC.CaseID = CA.CaseID 
AND TS.IsBilled = 0
AND     CC.ClientToBill = 1 
AND     CA.BillingType = 2 
AND     (C.AccessRights = 0 OR C.OwnerUserID = :uid OR (C.AccessRights = 2 AND     C.ClientID IN 
(SELECT ClientID FROM ClientRights WHERE UserID = :uid)))

Upvotes: 0

Steven Schroeder
Steven Schroeder

Reputation: 6194

SELECT DISTINCT
        c.ClientID
       ,c.ClientType
       ,c.ClientName
  FROM Clients c
 INNER JOIN CaseClients cc
    ON c.ClientID = cc.ClientID
 INNER JOIN TimeSheet ts
    ON cc.CaseID = ts.CaseID
 INNER JOIN Cases ca
    ON cc.CaseID = ca.CaseID
 WHERE ts.IsBilled = 0
   AND cc.ClientToBill = 1
   AND ca.BillingType = 2
   AND (c.AccessRights = 0 OR
        c.OwnerUserID = :uid OR
        c.AccessRights = 2 AND c.ClientID IN (SELECT cr.ClientID
                                                FROM ClientRights cr
                                               WHERE cr.UserID = :uid)
       )

Upvotes: 0

StevieG
StevieG

Reputation: 8709

This might speed it up a bit, but making sure you have the indexing correct will also help..

SELECT C.ClientID, C.ClientType, C.ClientName 
FROM Clients C
INNER JOIN CaseClients CC ON C.ClientID = CC.ClientID AND CC.ClientToBill = 1
INNER JOIN TimeSheet TS ON CC.CaseID = TS.CaseID AND TS.IsBilled = 0
INNER JOIN Cases CS ON CC.CaseID = CS.CaseId AND CS.BillingType = 2 
WHERE AccessRights = 0 
     OR OwnerUserID = :uid 
     OR 
        (
            AccessRights = 2 AND 
            ClientID IN (SELECT ClientID 
                            FROM ClientRights 
                            WHERE UserID = :uid)
        )
    )

Upvotes: 0

Related Questions