CODEWITHSUNDEEP
javascriptencryptionxor
Silviu-Marian
Silviu-Marian

Reputation: 10927

JavaScript - Bitwise XOR on strings?

I'm translating an encryption function from PHP to JS.

PHP: (Both $y and $z are ASCII characters, so $x is inherently an ASCII oddity.)

 $x = ($y ^ $z);

Doing the same in JS results in $x = 0.

I tried:

 $x = String.fromCharCode(($y).charCodeAt(0).toString(2) ^ ($z).charCodeAt(0).toString(2));

But it gets to a different result.

Upvotes: 18

Views: 28344

Answers (2)

copy
copy

Reputation: 3382

The toString(2) converts to a binary String, but you want to work on the Number type.

Simply drop the toString(2) part and it should work.

Upvotes: 10

zzzzBov
zzzzBov

Reputation: 179256

You don't need to convert it back to a string. Bitwise operators work on numbers. 1 ^ 310 is the same as 1 ^ 112 is the same as 1 ^ 103.

//this should work for single characters.
x = String.fromCharCode(y.charCodeAt(0) ^ z.charCodeAt(0));

Upvotes: 32

Related Questions