CODEWITHSUNDEEP
cstrcmpqsort
user1161080
user1161080

Reputation: 175

qsort segmentation fault

So I'm working on a program where the function reads in from stdio, and keeps reading in characters in chunks of n characters.

So far I've gotten it so that everything is stored in a character array called buffer. For the next step, I need to sort each chunk of n characters. For example the string cats/ndogs/n should be split as cats/n dogs/n if n =5, and then qsort() needs to alphabetize it. This is how I'm calling qsort():

qsort (buffer, (line-2)*n*(sizeof(char)),n,compare);

Where (line-2)*n*sizeof(char) gives the total number of items in the array buffer; 10 in this case.

This is my compare function:

int compare (const void * a, const void * b)
{
   return (strcmp(*(char **)a, *(char **)b));
}

When I run this, however, I always get a seg fault in strcmp(). Any ideas why?

This is the loading code:

while (!feof(stdin))
{
    for (i = 0; i < n; i++)
    {
        char l = getchar();
        if (l != EOF)
        {
            if ((i == 0) && (line != 1))
            {
                success = (int *)realloc(buffer, line*n*(sizeof(char)));
            }
            buffer[(n*(line-1))+i] = l;
        }
     }
     line = line + 1;
}

Upvotes: 2

Views: 1554

Answers (2)

wildplasser
wildplasser

Reputation: 44250

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

char buffer[] ="333000222555111777888666999444";

int mycmp(void *l, void*r);
int main(void)
{
/* note: sizeof buffer is 31,
** but the integer division will round down
** , ignoring the extra nul-byte */
qsort(buffer, (sizeof buffer/3), 3, mycmp);
printf ("[%s]\n", buffer);

return 0;
}

int mycmp(void *l, void *r)
{
return memcmp(l,r,3);
}

Upvotes: 0

Simon F
Simon F

Reputation: 1055

Silly question, but are your strings null terminated? You seem to only have a newline on the end.

Also, you probably only need "strcmp((char *)a, (char *)b)" as the extra *s look to be redundant to me.

Upvotes: 1

Related Questions