CODEWITHSUNDEEP
javascriptjquery
TMC
TMC

Reputation: 8154

jQuery/Javascript: How to get anonymous function to reference variable declare outside?

I have some jQuery code that doesn't work as expected.

$('a[href^="http://"]').not('[href^="http://mydomain.com"], [href^="http://itunes.apple.com"]').click(function (e) {
    e.preventDefault();
    console.log("external: " + this.getAttribute('href'));
    var url = this.getAttribute('href');
    foo.track(
        "External", 
        { 'URL': url }, 
        function (url) { 
            location.href = url 
        }
    );
});

For this example, I'm tracking all external clicks from my domain, except for iTunes apps store. Assume foo.track() is a 3rd party method I'm using to track some events for reporting. The last parameter to it is an anonymous function that is executed once the tracking call successfully returns.

The code above is trying to navigate everything to http://mydomain.com/1 for some reason. However, the console.log statement succesfully logs the expected values. It's as if the url variable isn't referencing the value I expect. I've also tried replacing location.href = url with window.location = url but I get the same result.

What am I doing wrong?

Upvotes: 1

Views: 698

Answers (1)

Diego
Diego

Reputation: 18359

Just remove the parameter from the navigation function. Like this:

$('a[href^="http://"]').not('[href^="http://mydomain.com"], 
                             [href^="http://itunes.apple.com"]').click(function (e) {
e.preventDefault();
console.log("external: " + this.getAttribute('href'));
var url = this.getAttribute('href');
foo.track("External", { 'URL': url }, function (/*url*/) { location.href = url });
});

Upvotes: 1

Related Questions