CODEWITHSUNDEEP
editnested-formsruby-on-rails-2
A1aks
A1aks

Reputation: 186

expected Hash (got Array) for param 'samples'

I have been following Railscasts episodes of Nested forms and complex forms. During the time of creating multiple model in a single form I was able to edit, update, delete and create records for sample models that were nested in the Batch model.

I have been breaking my head from a long time and tried searching around as well but could not get any right solution for solving this problem.

my development log file gives me the following error.

ERROR MESSAGE:

Status: 500 Internal Server Error
  expected Hash (got Array) for param `samples'

in my controller I have the update action like this 

def update
     @batch = Batch.find(params[:id])

     respond_to do |format|
       if @batch.update_attributes(params[:batch])
         flash[:notice] = 'Successfully updated Batch.'
         format.html { redirect_to(@batch) }
         format.xml  { head :ok }
       else
         format.html { render :action => "edit" }
         format.xml  { render :xml => @batch.errors, :status => :unprocessable_entity }
       end
     end
   end

my view is something like this:

<%= form_for @batch do |f| %>
......
<%= f.fields_for :samples do |s_form| %>
.... s_form things
<% end %>
<% end %>

my model contains the same stuff :

has_many :samples, :dependent => :destroy

  accepts_nested_attributes_for :samples, :reject_if => lambda { |a| a[:content].blank? }, :allow_destroy => true

All suggestions are appreciated.

Upvotes: 10

Views: 12927

Answers (4)

romanstrazanec
romanstrazanec

Reputation: 13

I had this problem, when the user typed the params himself in the request like:

https://example.com/page?samples[]=1&samples[test]=2

Debugging the code, I got down to a Rack::QueryParser.parse_nested_query method in the rack gem:

# parse_nested_query expands a query string into structural types. Supported
# types are Arrays, Hashes and basic value types. It is possible to supply
# query strings with parameters of conflicting types, in this case a
# ParameterTypeError is raised. Users are encouraged to return a 400 in this
# case.
def parse_nested_query(qs, d = nil)
  params = make_params

  unless qs.nil? || qs.empty?
    (qs || '').split(d ? (COMMON_SEP[d] || /[#{d}] */n) : DEFAULT_SEP).each do |p|
      k, v = p.split('=', 2).map! { |s| unescape(s) }

      normalize_params(params, k, v, param_depth_limit)
    end
  end

  return params.to_h
rescue ArgumentError => e
  raise InvalidParameterError, e.message, e.backtrace
end

From the docstring:

It is possible to supply query strings with parameters of conflicting types, in this case a ParameterTypeError is raised. Users are encouraged to return a 400 in this case.

I found few solutions here Rails ActionController::BadRequest causes 500 Server Error on production server

Upvotes: 0

Shristina
Shristina

Reputation: 181

I also got this error Invalid request parameters: expected Hash (got Array) for param 'cell'.

In my case, I misformed the field name like 

f.text_field :name, name: 'cell[name][]'

this was causing the error. Now I did the following and the error is gone:-

f.text_field :name, name: 'cell[][name]'

in this solution I was actually trying to get data in array format.

Upvotes: 0

Siwei
Siwei

Reputation: 21569

for others who met the same problem:

this error is caused when you have two fields in your form like:

video: 'some string'
video['url']:  'some url'

then rails will crash with the error: expected Hash (got String) for param

the solution is quite simple: change 'video' to something else. e.g.:

video_origin_url: 'some string'
video['url']: 'some url'

Upvotes: 18

theschmitzer
theschmitzer

Reputation: 12860

I had the same problem, and just fixed it.

Check the headers of your request. I mine I saw:

weight[2][name]:Tests
weight[2][value]:75
weight[1][name]:Quizzes
weight[1][value]:25
weight[][name]:Foo
weight[][value]:

It was the last two which caused the issue. In my case I had to give this weight an ID to get rid of the error.

Upvotes: 4

Related Questions