CODEWITHSUNDEEP
javascripttddjasmine
screenm0nkey
screenm0nkey

Reputation: 18805

Issues with Jasmine's spyOn toHaveBeenCalled method

Can anyone possibly tell me why the following test fails.

var Person = function() {};

Person.prototype.helloSomeone = function(toGreet) {
  return this.sayHello() + " " + toGreet;
};

Person.prototype.sayHello = function() {
  return "Hello";
};

describe("Person", function() {
 it("calls the sayHello() function", function() {
   var fakePerson = new Person();
   spyOn(fakePerson, "sayHello");
   fakePerson.helloSomeone("world");
   expect(fakePerson.sayHello).toHaveBeenCalled();
  });
});

I took it from here and he said it works. I can see the spyOn method is creating a wrapper function of the same name on the person object i.e. fakePerson.sayHello is being invoked on the object and not the prototype.

Many thanks

Upvotes: 1

Views: 5766

Answers (2)

HoLyVieR
HoLyVieR

Reputation: 11134

One possible problem with your test cases is that you haven't specified that the original method should be called. What would have a proper behavior is the following (note the "andCallThrough") : 

describe("Person", function() {
 it("calls the sayHello() function", function() {
   var fakePerson = new Person();
   spyOn(fakePerson, "sayHello").andCallThrough();
   fakePerson.helloSomeone("world");
   expect(fakePerson.sayHello).toHaveBeenCalled();
  });
});

You can see the documentation page of Jasmine for more information about the other possibility : https://github.com/pivotal/jasmine/wiki/Spies

Edit: A quick look at the jasmine-sinon documentation brings up the following:

Warning

jasmine-sinon currently overwrites any Jasmine matchers of the same name used for its own spying features. I plan to allow these to be optionally retained in the future.

The native Jasmine matchers that are overwritten are:

  • toHaveBeenCalled()
  • toHaveBeenCalledWith()

If you want to use jasmine-sinon, you have to use their API and not the one of Jasmine.

Edit: As of Feb 2012:

You can also use Jasmine spies alongside your Sinon spies. jasmine-sinon will detect which you're using and use the appropriate matcher.

Upvotes: 4

screenm0nkey
screenm0nkey

Reputation: 18805

The tests failed because I was also using jasmine-sinon.js.

Upvotes: 8

Related Questions