CODEWITHSUNDEEP
javagarbage-collectioninner-classes
James Faulkner
James Faulkner

Reputation: 271

Are non-static inner class objects garbage collected after they are no longer referenced?

I have a single spring bean similar to the following:

public class MyServiceImpl {
    private MyDAO myDAO;

    public class MyInnerClass implements SomeInterface<MyInnerClass> {

        @Override
        public MyInnerClass loadFreshObject(final String key) {
            return myDAO.load(key);
        }
    }

}

Instances of MyInnerClass are being created in code outside of the spring bean but no reference to those instances are being kept.

Assuming I have no control over the use of these public non-static inner classes (I know ideally these would be private and static to avoid leaking the reference to 'this'), will the created instances of 'MyInnerClass' be correctly garbage collected?

I have run my own tests on this by overriding the finalize() and it appears that the instances are correctly being garbage collected, I was just hoping for clarification on this.

Thanks

Upvotes: 16

Views: 4471

Answers (4)

Michał Kosmulski
Michał Kosmulski

Reputation: 10020

Instances of the inner class will be garbage collected according to normal rules (i.e. when they are no longer referenced). However, each instance of the inner class contains a hidden reference to its parent instance of the outer class. This means that if there are any live references to instances of the inner class, they will prevent the associated instances of the outer class from being garbage collected. But it only works in that direction, not the other way around.

Upvotes: 26

Amir Pashazadeh
Amir Pashazadeh

Reputation: 7322

Of course, by the way, if your instances are kept by Spring as singleton beans, Spring (but not your code) will keep reference to them and they won't be garbage collected.

Upvotes: 0

JB Nizet
JB Nizet

Reputation: 692231

Why wouldn't they garbage collected? The GC doesn't care about the type of an object. If it's unreachable, it's GCed. If it's reachable, it's not GCed.

Upvotes: 2

Pavan
Pavan

Reputation: 1247

If there are no references to the object, it will be marked for collection. So, it should be fine, even if it is public, non-static inner class.

The other way around i.e. if there were references to these inner class objects, then the outer class object wont be collected, even there are no direct references to it.

Upvotes: 0

Related Questions