CODEWITHSUNDEEP
javaandroidif-statementandroid-edittext
lrobb
lrobb

Reputation: 82

Why doesn't this if statement work?

I'm trying to create an if statement, for example if the user doesn't type anything into the the two edit text's, then it displays a toast and resets everything. But for some reason, my code completely ignores this and just goes to the else statement instead.

Can anyone help?

My Code: package com.gta5news.bananaphone;

import java.io.File;

import android.R.string;
import android.app.Activity;
import android.content.Intent;
import android.content.SharedPreferences;
import android.os.Bundle;
import android.os.Environment;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.CheckBox;
import android.widget.EditText;
import android.widget.TextView;
import android.widget.Toast;

 public class LogIn extends Activity implements OnClickListener {
Button send;
EditText user;
EditText pass;
CheckBox staySignedIn;
SharedPreferences shareduser;
SharedPreferences sharedpass;
public static String settings = "MySharerdUser";

@Override
protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState);
    setContentView(R.layout.login);
    send = (Button) findViewById(R.id.bLogIn);
    user = (EditText) findViewById(R.id.eTuser);
    pass = (EditText) findViewById(R.id.eTpassword);
    staySignedIn = (CheckBox) findViewById(R.id.Cbstay);
    send.setOnClickListener(this);
    SharedPreferences settings = getPreferences(MODE_PRIVATE);
    String name = settings.getString("name", "");
    String password = settings.getString("pwd", "");
    user.setText(name);
    pass.setText(password);

    if (staySignedIn.isChecked()) {
        SharedPreferences MySharedUser = getPreferences(MODE_PRIVATE);
        settings.edit().putString("name", user.getText().toString())
                .putString("pwd", pass.getText().toString()).commit();
    }

    if (user.length() > 0)
        ;

}

public void onClick(View v) {
    // TODO Auto-generated method stub
    switch (v.getId()) {
    case R.id.bLogIn:
        if (user.length() < 0)  
    Toast.makeText(this,
            "Try to type in your username and password again!",
            Toast.LENGTH_LONG).show(); 
    else {
        String u = user.getText().toString();
        String p = pass.getText().toString();
        Bundle send = new Bundle();
        send.putString("key", u);
        send.putString("key", p);
        Intent a = new Intent(LogIn.this, FTPClient.class);
        startActivity(a);
        Toast.makeText(this, "Yay, you signed in!", Toast.LENGTH_LONG)
                .show();
        break;
    }
    }

}

}

Upvotes: 0

Views: 382

Answers (3)

FROSTYSMOOTH
FROSTYSMOOTH

Reputation: 77

Do you need an onClickListener for you checkbox???

checkbox.setOnClickListener(new OnClickListener() {
public void onClick(View v) {
    // Perform action on clicks, depending on whether it's now checked
    if (((CheckBox) v).isChecked()) {
        Toast.makeText(HelloFormStuff.this, "Selected", Toast.LENGTH_SHORT).show();
    } else {
        Toast.makeText(HelloFormStuff.this, "Not selected", Toast.LENGTH_SHORT).show();
    }
}

});

Upvotes: 0

Vyacheslav Shylkin
Vyacheslav Shylkin

Reputation: 9791

You have to use 

user.getText().toString().length()

Upvotes: 0

Samir Mangroliya
Samir Mangroliya

Reputation: 40406

 if (user.length() == 0)

try it because user.length() is never come in Less Than Zero

Upvotes: 3

Related Questions