CODEWITHSUNDEEP
c#class
Kenneth Bo Christensen
Kenneth Bo Christensen

Reputation: 2294

Defining a property within a class

Many times I have seen code where they write a Class like this:

public class Detail
{
    public Detail()
    {
        this.ColumnCtrl = new List<UserControl>();
    }
    public List<UserControl> ColumnCtrl { get; set; }
}

But if I only write the following – it works very fine also:

public class Detail
{
    public List<UserControl> ColumnCtrl { get; set; }
}

Is there any reason to write my get-set Classes like in the first example?

Upvotes: 1

Views: 99

Answers (6)

M.Babcock
M.Babcock

Reputation: 18965

Your first example initializes the ColumnCtrl property to a value when the Detail class is constructed, where your second one will be left null. If it isn't initialized elsewhere you should expect NullReferenceExceptions.

As long as you initialize the ColumnCtrl property explicitly before use when using your second example, they are exactly the same thing.

Detail newDetail = new Detail();
newDetail.ColumnCtrl = new List<UserControl>();
newDetail.ColumnCtrl.Add(new UserControl());

An alternative (though slightly more verbose) would be to lazily instantiate the ColumnCtrl property to eliminate the overhead of instantiating it when Detail is constructed:

public class Detail
{
    public Detail()
    {
        this.ColumnCtrl = new List<UserControl>();
    }
    private List<UserControl> columnCtrl = null;
    public List<UserControl> ColumnCtrl
    {
        get 
        {
            // Missing appropriate locking mechanisms for brevity
            if (columnCtrl == null)
                columnCtrl = new List<UserControl>();

            return columnCtrl;
        }
        // The set is not absolutely necessary if you never need to set it
        // from outside of Details but if you do...
        set
        {
            columnCtrl = value;
        }
    }
}

Upvotes: 0

Michal B.
Michal B.

Reputation: 5719

There is a reason to write it the way it is done in the first example. It is the initialization of the property. In the second case if you type:

var detail = new Detail();
var count = detail.ColumnCtrl.Count

you will get exception, because ColumnCtrl is not initialized.

You do not always need to initialize, e.g. there is no need to initialize when you use dependency injection or if you check for null in a ColumnCtrl getter and initialize it the first time it's requested.

Upvotes: 1

aweis
aweis

Reputation: 5596

In the second situation the ColumnCtrl is not assigned a value. In The first case you make sure that the ColumnCtrl is assigned an empty list by default.

Upvotes: 0

Jon
Jon

Reputation: 40032

The first one always ensures that a instance of a List is returned because the constructor creates a new instance. If you dont have that in the constructor it will return a null in the property.

If you then did:

Detail myInstance = new Detail();
myInstance.ColumnCtrl.Add........  //NullReferenceException is thrown here!

Upvotes: 1

asawyer
asawyer

Reputation: 17808

The second example does not create a new instance for the property, and if you access it directly after creating an instance of Detail you will throw a null reference exception.

In the first example, they are insuring this will not happen.

Upvotes: 1

Justin Niessner
Justin Niessner

Reputation: 245389

Yes, because the second example will never be initialized when the class is instantiated.

In the first example, the following statement would work:

var detail = new Detail();
detail.ColumnCtrl.Add(new UserControl());

Whereas in the second it would fail with a NullReferenceException unless you initialize it yourself before using it.

Upvotes: 1

Related Questions