CODEWITHSUNDEEP
phpcodeignitercookies
danny
danny

Reputation: 475

Why doesn't cookie work in CodeIgniter?

I use this function to add cookie and it adds perfectly as I can see in browser options.

function login($username,$password){

    $cookieUsername = array(
        'name'   => 'user',
        'value'  => md5($username),
        'expire' => time()+1000,
        'path'   => '/',
        'secure' => TRUE
    );

    $cookiePassword = array(
        'name'   => 'pass',
        'value'  => $password,
        'expire' => time()+1000,
        'path'   => '/',
        'secure' => TRUE
    );

    $this->input->set_cookie($cookieUsername);
    $this->input->set_cookie($cookiePassword);

}

I am unable to get back the cookie from this function:

 echo $this->input->cookie('user');

Please help - how can I get cookie back from CodeIgniter?

Upvotes: 5

Views: 25666

Answers (13)

Serj
Serj

Reputation: 41

I had the same problem on localhost when I added

$config['cookie_domain']    = 'http://localhost:8888/mywebsite/';

After I inspected Application tab under Developer Tools in Chrome it showed that all cookies from all websites on localhost are stored under http://localhost:8888. You cannot add a specific local website into $config['cookie_domain'] while working on localhost. You can use this config only for a real domain name www.mywebsite.com on your public server. On localhost leave this config empty.

Upvotes: 0

Haritsinh Gohil
Haritsinh Gohil

Reputation: 6272

There is nothing wrong with Cookies in codeigniter it is working perfectly as expected,

the problem is in your syntax, the expiry date you have set in expire is incorrect.

because codeigniter add your provided value to current time, so if you want to set 30 days expiration from now on then you have to only provide value like 86400*30 in expire

then it will work ok for example: 'expire'=> 86400 * 30

when You provide value like time()+1000 it add that much value in time() so it becomes double of current time and browser count it as incorrect value,

And when you have an incorrect expire value, it defaults to 0, which is set as your session's length instead,

and because of that when your session expire means browser closes or window closes, cookies are also reset because session expires.

so the right example is as below:

$cookie = array(
   'name'   => 'user',
   'value'  => md5($username),
   'expire' => 86400*30,
   'secure' => TRUE
);
set_cookie($cookie);

Or another way is:

set_cookie('user',md5($username),86400*30);
//syntax
//set_cookie($name[, $value = ''[, $expire = ''[, $domain = ''[, $path = '/'[, $prefix = ''[, $secure = NULL[, $httponly = NULL]]]]]]])

Upvotes: 0

Karlo Kokkak
Karlo Kokkak

Reputation: 3714

Codeigniter, in its code, already adds time() for expiry, so you don't need to add time() in your cookie config.

Change:

 'expire' => time()+1000

To:

'expire' => 1000

Also use the procedural style cookie helper functions such as (set_cookie, get_cookie, delete_cookie..) as they automatically adds the cookie prefix config, while with the OOP ones ($this->input->set_cookie etc.), you will have to manually type in the cookie prefix config as well each time.

Upvotes: 1

Erdinç Çorbacı
Erdinç Çorbacı

Reputation: 1213

Check your config.php for cookie_secure directive. It must be FALSE for non-https domains.

If domain is not https and cookie_secure is set TRUE in config.php, cookies simply will not be set. Change to FALSE and it will be set in both http and https.

Upvotes: 2

starkraving
starkraving

Reputation: 91

Switching to PHP's setcookie() instead of CI's $this->input->set_cookie() didn't work for me; the cookie was still not available until the next request. This makes sense because CI's method in fact generates a setcookie() so they're functionally equivalent. However, I was able to get it working right away by doing the following:

//this is the original code, which is made available next request:
$this->input->set_cookie('foo', 'bar', 86500);
//this is what I added, to make the cookie available immediately:
$_COOKIE['foo'] = 'bar';

Hope that helps someone.

Upvotes: 4

Pradip Parmar
Pradip Parmar

Reputation: 301

public function cookie()
{
    $this->load->helper('cookie');

    $name   = 'user';
    $value  = 'pradip';
    $expire = time()+1000;
    $path  = '/';
    $secure = TRUE;

    setcookie($name,$value,$expire,$path); 

    $this->load->view('welcome_message');

}

call in view page like echo $this->input->cookie('user');

output = pradip

Upvotes: 1

oparam
oparam

Reputation: 209

First make sure you are including cookie helper:

$this->load->helper('cookie');

And set cookie like this:

set_cookie($cookie_name, $value, $time);

Upvotes: 0

danny
danny

Reputation: 475

Its problem with CI built in function which writes the cookie. What i changed is now i am setting cookie whith 

setcookie($name,$value,$expire,$path);

function and getting it back through 

$this->input->cookie('user',TRUE);

this is work damn fine!

Upvotes: 12

user4962466
user4962466

Reputation:

That is caused by an incorrect initialization of function set_cookie() about $expire parameter, setted to empty string by default but it must be setted to 0 by default because it rapresent timestamp. Look at there correction

Line 342 on system/core/Input.php

https://github.com/diegomariani/CodeIgniter/commit/64ac9e711100605f41a3b37bc897a12063fed70b

Upvotes: 1

Matt Saunders
Matt Saunders

Reputation: 4391

I was having this problem and found that Codeigniter requires an expiry value, NOT just the name and value as stated in the documentation. I.e. 

$cookie = array(
'name'  => 'logged',
'value'  => 1,
'expire' => '86500',
);

set_cookie($cookie);

Upvotes: 3

maikel
maikel

Reputation: 1165

there is a bug in codeigniter: it doesn't use your cookie_prefix when reading the cookie (when writing the cookie, it does) see /system/core/Input.php in function cookie

Upvotes: 0

stormdrain
stormdrain

Reputation: 7895

Check your config.php cookie settings. If they are set wrong, cookies won't work. The defaults work for me locally using your code

$config['cookie_prefix']    = '';
$config['cookie_domain']    = '';
$config['cookie_path']      = '/';

also, you should encrypt the password if you're going to encrypt anything. And you shouldn't use md5. Use CI's built in encryption ($this->encrypt->encode();) which uses a safer algorithm [don't forget to set your encryption key in config.php].

Upvotes: 2

Shiplu Mokaddim
Shiplu Mokaddim

Reputation: 57690

You can not get cookie on the same http request. Once you set a cookie it must be sent to browser by Set-Cookie header. And you can not send header until the http transaction is completed. After that browser will get the cookie and on the next request browser will send it to server by Cookie header.

From PHP.NET

Cookies will not become visible until the next loading of a page that the cookie should be visible for. To test if a cookie was successfully set, check for the cookie on a next loading page before the cookie expires. Expire time is set via the expire parameter.

So the cookie will be available on the next page load.

Upvotes: 8

Related Questions