CODEWITHSUNDEEP
c#silverlightwindows-phone-7
firebellys
firebellys

Reputation: 906

WebClient does not support concurrent I/O operations

How can I get this error from with in the DownloadStringCompleted Event? Doesn't that mean, it's finished? Is there another event I can fire this from?

I get this error extremely rarely, but once in a while it will happen on my WP7 phone. I have a web client that I fire over and over, and I fire it again from the completed event. Is this happening because there is still some stale connection open? Is there a way to prevent this 100%?

I have checked to see if there is a chance for the thread to walk over itself, but it is only fired from within the completed event.

How can I be sure, when the complete event is fired, the client is no longer isBusy? One suggestion was to add a while with a thread sleep while the client is busy.

Some pseudo code.

var client = new WebClient("URL 1");
client.CompletedEvent += CompletedEvent;
client.downloadasync();

void CompletedEvent(){
Dosomestuff;
client.downloadasync(); //This is where we break.
}

Upvotes: 24

Views: 36195

Answers (6)

hossein.sharifipour
hossein.sharifipour

Reputation: 121

        private async Void SyncParcelStatus(List<string> Urls)
        {                               
                try
                {                    
                    foreach (var URL in WebhookUrls)
                    {                        
                            Task.Factory.StartNew(() => AsyncDownLoad(URL));                       
                    }
                }
                catch (Exception ex)
                {
                    //log Exception 
                }
        }

        private async void AsyncDownLoad(string URL)
        {
            using (WebClient myWebClient = new WebClient())
            {
                try
                {
                    Uri StringToUri = new Uri(URL);
                    myWebClient.DownloadStringAsync(StringToUri);
                }
                catch (Exception ex)
                {
                    //log Exception
                }
            }
        }

Upvotes: 0

nixish
nixish

Reputation: 21

Create a new Web Client for each new request. Don't reuse an existing Web Client instance.

This allows the first request to complete before starting the new one. This is a standard way of creating new requests.

Upvotes: 0

Ahamed Ishak
Ahamed Ishak

Reputation: 1062

Instead of using WebClient use HttpClient to do parallel HTTP calls. Below code shows how to download files.

        HttpClient httpClient = new HttpClient();
        var documentList=_documentManager.GetAllDocuments();
        documentList.AsParallel().ForAll(doc =>
        {

            var responseResult= httpClient.GetAsync(doc.FileURLPath);
            using (var memStream = responseResult.Result.Content.ReadAsStreamAsync().Result)
            {
                using (var fileStream =File.Create($"{filePath}\\{doc.FileName}"))
                {
                    memStream.CopyTo(fileStream);
                }

            }
        });

Upvotes: 11

Fiach Reid
Fiach Reid

Reputation: 7059

The solution, I found is to use multiple WebClient objects, so to modify your pseudocode example; try

var client = new WebClient("URL 1");
client.CompletedEvent += CompletedEvent;
client.downloadasync();

void CompletedEvent(){
Dosomestuff;
var client2 = new WebClient();
client2.downloadasync(); 
}

Upvotes: 0

firebellys
firebellys

Reputation: 906

The only answer is to create a new webclient within the scope of the Completed Event. You can't set it to new since webclient is readonly. Creating a new client is the only solution. This allows the old client to complete in the background. This does have slight memory implications since you are creating a new instance instead of reusing an old. But the garbage collector should keep it clean if your scope is setup right.

Upvotes: 10

ColinE
ColinE

Reputation: 70142

The WebClient only supports a single operations, it cannot download multiple files. You haven't shown your code, but my guess is that you are somehow firing a new request before the old is completed. My bet is that WebClient.IsBusy is true when you attempt to perform another fetch.

See the following thread:

wb.DownloadFileAsync throw "WebClient does not support concurrent I/O operations." exception

Upvotes: 20

Related Questions