user1147768
user1147768

Reputation:

StringIndexOutOfBoundsException in android

I am getting the following error:

    java.lang.StringIndexOutOfBoundsException: length=13243; regionStart=32; regionLength=-39
    at java.lang.String.startEndAndLength(String.java:593)
    at java.lang.String.substring(String.java:1474)
    at com.dict.XMLParser.getResultFromXML(XMLParser.java:63)
    at com.dict.InternetDictProvider.searchWord(InternetDictProvider.java:29)
    at com.dict.SearchDict$SearchOnline.doInBackground(SearchDict.java:130)
    at com.dict.SearchDict$SearchOnline.doInBackground(SearchDict.java:1)
    at android.os.AsyncTask$2.call(AsyncTask.java:264)
    at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
    at java.util.concurrent.FutureTask.run(FutureTask.java:137)
    at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:208)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
    at java.lang.Thread.run(Thread.java:856)

in the following code which typically gets results after parsing the XML page given as HttpResponse to a HttpGet :

        retry:
        {
            DefaultHttpClient httpClient = new DefaultHttpClient();
            HttpGet httpGet = new HttpGet("http://oxforddictionaries.com/definition/"+query+"?q="+query);
            HttpResponse httpResponse = httpClient.execute(httpGet);
            HttpEntity httpEntity = httpResponse.getEntity();
            String meanings=parser.getResultFromXML(StringUtils.inputStreamToString(httpEntity.getContent()));
            if(meanings==null && firstRetry)
            {
                firstRetry=false;
                query = query.substring(0, 1).toUpperCase() + query.substring(1);
                break retry;
            }
            else if(meanings==null && !firstRetry)
                return query;
            result = query + ":" + meanings;
        }

Upvotes: 2

Views: 7768

Answers (1)

Samir Mangroliya
Samir Mangroliya

Reputation: 40416

 query = query.substring(0, 1).toUpperCase() + query.substring(1);

i think this statement create exeption so use if(null!=query&&query.length()!=0){query=...}

and if you substring your string length more than 1 in your case

Upvotes: 5

Related Questions