CODEWITHSUNDEEP
phparrays
Paul
Paul

Reputation: 385

PHP array not updating

There is probably something dumb I am doing wrong here.

public function get_scores($id)
{
    $results = array();
    $sql = "SELECT * FROM scores WHERE comp_id = $id";
    $rows = $this->db->query($sql)->result();
    foreach($rows as $row) {
        if($row->confirmed_id) {
            $results[$row->uid] += $row->score;
        }
    }
    sort($results);
    return $results;
}

So basically what I am trying to do is add all of the users scores in the database and return them in order of rank. confirmed->id is just a check to make sure the score has been confirmed (and thus is addable to their total score). I am basically trying to just make an associative array where the key is the users ID, and the score of each question they have in the database is added on. The query works fine, and $row-uid and $row->score both return the correct thing for every row, but $results[] never has anything added to it. If I even change it just to something silly like $results[3] = 0 at top, and then $results[3]++ or += 1 in the for loop, it doesn't add anything to $results[3].

EDIT: Problem solved. Indeed was something dumb -- confirmed_id was set to null by my partner when he reran our database after I had previously set it all to 1. Thanks guys :)

Upvotes: 0

Views: 1464

Answers (2)

Thilanka
Thilanka

Reputation: 1763

You need to remove the "+=" operation from the code. Check with this. 

public function get_scores($id)
{
    $results = array();
    $sql = "SELECT * FROM scores WHERE comp_id = $id";
    $rows = $this->db->query($sql)->result();
    foreach($rows as $row)
        if($row->confirmed_id)
            $results[$row->uid] = $row->score;
    sort($results);
    return $results;
}

Your previous operation is similar to 

$results[$row->uid] = $results[$row->uid] + $row->score;

So it will not add values to your row.

Upvotes: 0

Mark Fraser
Mark Fraser

Reputation: 3198

You are adding to $results[something] before it exists. You need to create it in the first case and then only increment it once it exists.

Upvotes: 2

Related Questions