CODEWITHSUNDEEP
c#wpf
davisoa
davisoa

Reputation: 5439

Changing Data Context for Data Template clears Combo Box selection

I have a TreeView that permits the user to select different items. The display for each item is determined using Data Templates with the DataType set to the appropriate ViewModel type. The DataContext is automatically set based on the selected item in the tree view to the appropriate ViewModel.

Here's the problem:

One of the DataTemplates has a ComboBox bound to an ObservableCollection to get the list of items and a property to get/set the SelectedValue in the ViewModel.

When I select one item of this type, and then select another item of the same type, the ComboBox displays blank instead of the correct selected item. It appears that the Combo Box is setting the SelectedValue property to NULL immediately after the transition to the new item, and then never updating.

<ComboBox Margin="1,0" 
    ItemsSource="{Binding ItemsToSelect}" 
    SelectedValue="{Binding SelectedValue}" 
    SelectedValuePath="ValuePath" DisplayMemberPath="DisplayPath"
    IsEnabled="{Binding CanSelectItem}">
</ComboBox>

The really strange part is if I select an item of a different type between selecting items of the same type, it always displays correctly.

I've tried ignoring the NULL value in the SelectedValue setter, and that didn't work regardless of whether I also raised the PropertyChanged event or not.

private MyObject selectedValue;
public MyObject SelectedValue
{
    get
    {
        return selectedValue;
    }
    set
    {
        if (value != null)
        {
            this.selectedValue = value;
        }
        this.OnPropertyChanged("SelectedValue");
    }
}

Looking at the similar questions while writing this lead me to an interesting attribute that I hadn't found yet - IsSynchronizedWithCurrentItem from this question. At first, I thought this solved the problem, but alas it just changes the behavior somewhat.

With this attribute set to True, the combo doesn't entirely clear its selection, but instead just marks the first item as selected. So, instead of being set to NULL, now the SelectedValue property is being set to the first item in the list.

Anyone have any ideas for a solution?

Upvotes: 2

Views: 986

Answers (2)

davisoa
davisoa

Reputation: 5439

I figured out a work around, but it isn't quite what I wanted.

I changed the binding to use SelectedItem instead of SelectedValue, and the issue doesn't occur.

I got the idea from this question.

So I changed

SelectedValue="{Binding SelectedValue}"

To (and renamed my ViewModel Property):

SelectedItem="{Binding SelectedItem}"

After updating the uses of this property in the ViewModel, everything worked.

Upvotes: 1

Remy
Remy

Reputation: 252

If I understand your problem correctly, a couple of things are going on here.

First you do not have Mode=TwoWay, UpdateSourceTrigger=PropertyChanged} set in your bindings.

Second, the property binding will only update if there is a change in the value itself.

Check this out Data Binding

Upvotes: 1

Related Questions