CODEWITHSUNDEEP
javaprocesslocking
Leo
Leo

Reputation: 171

Locking a process in Java

I have a Java servlet which calls another software (say S) over a TCP connection. This software S uses a network resource, and the output has to be retrived from a hyperlink(using wget).

Since it's the same hyperlink I need to download my result from (irrespective of the request), it results into incorrect results few requests. I basically need to lock the use of this network resource across different processes (I believe each call from the servlet is going to create a new process).

I tried to use ReentrantLock (but I guess it only works with threads and not accross processes).

Please let me know how can this be achieved.

Thanks

Upvotes: 1

Views: 3062

Answers (3)

Java42
Java42

Reputation: 7706

Here is how to do cross-process locking in Java. Adjust to your needs and add error/exception checking/handling as necessary.

// Tester 
try { 
  if (crossProcessLockAcquire(SomeClassInYourApp.class, 3000)) { 
    // Success - This process now has the lock. (Don't keep it too long.) 
  } 
  else { 
    // Fail (Timeout) - Another process still had the lock after 3 seconds. 
  } 
} finally { 
  crossProcessLockRelease(); // try/finally is very important. 
} 

// Acquire - Returns success ( true/false ) 
private static boolean crossProcessLockAcquire(final Class<?> c, final long waitMS) { 
if (fileLock == null && c != null && waitMS > 0) { 
    try { 
        long dropDeadTime = System.currentTimeMillis() + waitMS; 
        File file = new File(lockTempDir, c.getName() + ".lock"); 
        RandomAccessFile randomAccessFile = new RandomAccessFile(file, "rw"); 
        FileChannel fileChannel = randomAccessFile.getChannel(); 
        while (System.currentTimeMillis() < dropDeadTime) { 
            fileLock = fileChannel.tryLock(); 
            if (fileLock != null) { 
                break; 
            } 
            Thread.sleep(250); // 4 attempts/sec 
        } 
    } catch (Exception e) { 
        e.printStackTrace(); 
    } 
} 
return fileLock == null ? false : true; 
} 

// Release 
private static void crossProcessLockRelease() { 
if (fileLock != null) { 
    try { 
        fileLock.release(); 
        fileLock = null; 
    } catch (IOException e) { 
        e.printStackTrace(); 
    } 
} 
} 

// Some class vars and a failsafe lock release. 
private static File lockTempDir = new File(System.getProperty("java.io.tmpdir") + File.separator + "locks"); 
private static FileLock fileLock = null; 
static { 
Runtime.getRuntime().addShutdownHook(new Thread() { 
    public void run(){ 
        crossProcessLockRelease(); 
    } 
}); 
}

Upvotes: 2

Peter Lawrey
Peter Lawrey

Reputation: 533492

The resource you are trying to lock has to support looking. It would be better if the service didn't need to be locked externally.

As a work around you can use a ServerSocket to lock a resource between processes.

Upvotes: 0

Brendan Long
Brendan Long

Reputation: 54242

Why are you reusing this TCP connection? If it's easy to set up, just set one up every time you need it. For example, with an HTTP request, you should just make a new request every time.

My guess is that you have something static that shouldn't be, so multiple threads are using it when they should all have their own version.

If they're expensive, consider creating one-per-thread with ThreadLocal.

If even that doesn't work, and you don't mind threads blocking, just add "synchronized" to the method that's causing the problem.

Upvotes: 0

Related Questions