CODEWITHSUNDEEP
iphoneobjective-cios
Alec
Alec

Reputation: 979

Change Value of Duplicate Object in NSMutableArray?

I have the method below, which in my Blackjack app will get the value of the hand which is an NSMutableArray. The problem here is that when 2 Ace's are in a hand, it should be a 12, but because it counts Ace's as 11, it results in being 22, which then makes lowValue returned.

How can I make it so that I can check and see if the for loop has already found an Ace and if it finds another, makes the next Ace worth only 1, not 11?

Thanks!

int getHandValue(NSMutableArray *hand) {
    int lowValue = 0;
    int highValue = 0;

    for (KCCard *aCard in hand) {
            if (aCard.value == Ace) {
                lowValue+= 1;
                highValue+= 11;
            } else if (aCard.value == Jack || aCard.value == Queen || aCard.value == King) {
                lowValue += 10;
                highValue += 10;
            } else {
                lowValue += aCard.value;
                highValue += aCard.value;
            }
    }

    return (highValue > 21) ? lowValue : highValue;     
}

Upvotes: 0

Views: 99

Answers (3)

zsxwing
zsxwing

Reputation: 20816

int getHandValue(NSMutableArray *hand) {
    int lowValue = 0;
    int highValue = 0;
    BOOL isFoundAce = NO;

for (KCCard *aCard in hand) {
        if (aCard.value == Ace) {
            if (isFoundAce) {
                 lowValue+= 1;
                 highValue+= 1;
            }
            else {
                 lowValue+= 1;
                 highValue+= 11;
                 isFoundAce= YES;
            }

        } else if (aCard.value == Jack || aCard.value == Queen || aCard.value == King) {
            lowValue += 10;
            highValue += 10;
        } else {
            lowValue += aCard.value;
            highValue += aCard.value;
        }
}

return (highValue > 21) ? lowValue : highValue;     
}

Upvotes: 0

Gargo
Gargo

Reputation: 704

My example without a redundant code from zsxwing's example:

int getHandValue(NSMutableArray *hand) {
    int cardValue = 0;
    int aceCount = 0;
    for (KCCard *aCard in hand) {
        if (aCard.value == Ace) {
            aceCount++;
            cardValue += 11;
        } else if (aCard.value == Jack || aCard.value == Queen || aCard.value == King) {
            cardValue += 10;
        } else {
            cardValue += aCard.value;
        }
    }
    while ((cardValue > 21) && (aceCount > 0)) {
        cardValue -= 10;
        aceCount--;
    }
    return cardValue;
}

Upvotes: 0

tams
tams

Reputation: 830

Perhaps you can add a boolean value before the for loop setting it initially to NO. When an Ace is found then you can break from the for loop after setting the boolean to YES, that way if you encounter another Ace && your boolean value == YES you can handle the case accordingly.

Upvotes: 1

Related Questions