CODEWITHSUNDEEP
c#arrayscomparisonequality
jarus
jarus

Reputation: 1873

How to equate the elements of two array irrespective of the order of entries

I am trying to tally two arrays like myArray{a,b,c} and urArray{a,b,c,c}

I wanted to check if both the elements have same elements ,for example in above condition the second array that is urArray has an extra 'c' .

And the code should be able to equate two sets of array if they have the same elements or not and the order of the elements doesn't matter. Just that both arrays should have same elements i.e if one has two 'c' the other should also have two 'c' otherwise the condition is false.

So what I did was:

char[] myArray = new char[] {'a','b','c','c'};
char[] urArray = new char[] { 'a', 'b', 'c' ,'a'};
List<char> tmp2 = new List<char>(urArray);

for (int i = 0; i < myArray.Length; ++i)
{
    for (int j = 0; j < urArray.Length; ++j)
    {
        if (myArray[i] == urArray[j])
        {

            Console.WriteLine(urArray[j] + "--> " + "urArray"+"  myArray"+"--> "+myArray[i]);
            tmp2.Remove(urArray[j]);

            urArray = tmp2.ToArray();

        }
        else if (myArray[i] != urArray[j])
        {
            Console.WriteLine(myArray[i] + "--> " + "myArray" + "  urArray" + "--> " + urArray[j]);
        }
    }
}

but have no idea how to show that if the array have same elements or not ...

How can I accomplish this?

Upvotes: 1

Views: 7535

Answers (9)

m1k4
m1k4

Reputation: 829

return myArray.OrderBy(c => c).SequenceEqual(urArray.OrderBy(c => c));

Upvotes: 1

TonyAbell
TonyAbell

Reputation: 1330

First you one should check if the arrays are the same length.

If they are then we need to sort the arrays.

Then loop through both arrays and compare each element.

    char[] myArray = new char[] { 'a', 'b', 'c', 'c' };
    char[] urArray = new char[] { 'a', 'b', 'c', 'a' };


    if (myArray.Length.Equals(urArray.Length))
    {
        ///
        /// sort arrays
        ///

        System.Array.Sort(myArray);
        System.Array.Sort(urArray);

        for (int i = 0; i < myArray.Length; i++)
        {
            if (myArray[i] != urArray[i])
            {
                ///
                /// Arrays do not have same elements.
                ///
                break;

            }

        }
        ///
        /// if reach this code path the two arrays are equal.
        ///


    } else
    {
        ///
        /// Arrays not equal lenght
        ///

    }

Upvotes: 0

Daniel Br&#252;ckner
Daniel Br&#252;ckner

Reputation: 59655

I suggest to calculate the difference between the histograms of both sequences. This will even work if the sequence cannot be sorted or there is no efficient way to determine the length of a sequence. 

public static Boolean CompareCollections<T>(IEnumerable<T> a, IEnumerable<T> b)
{
    Dictionary<T, Int32> histogram = new Dictionary<T, Int32>();

    foreach (T item in a)
    {
        Int32 count;
        if (histogram.TryGetValue(item, out count))
        {
            histogram[item]++;
        }
        else
        {
            histogram[item] = 1;
        }
    }

    foreach (T item in b)
    {
        Int32 count;
        if (histogram.TryGetValue(item, out count))
        {
            if (count <= 0)
            {
                return false;
            }

            histogram[item]--;
        }
        else
        {
            return false;
        }
    }

    foreach (Int32 value in histogram.Values)
    {
        if (value != 0)
        {
            return false;
        }
    }

    return true;
}

If the length of the sequence can be obtained, checking all values in the dictionary to be zero can be replaced by an check for equal sequence lengths.

public static Boolean CompareCollections<T>(ICollection<T> a, ICollection<T> b)
{
    if (a.Count != b.Count)
    {
        return false;
    }

    Dictionary<T, Int32> histogram = new Dictionary<T, Int32>();

    foreach (T item in a)
    {
        Int32 count;
        if (histogram.TryGetValue(item, out count))
        {
            histogram[item]++;
        }
        else
        {
            histogram[item] = 1;
        }
    }

    foreach (T item in b)
    {
        Int32 count;
        if (histogram.TryGetValue(item, out count))
        {
            if (count <= 0)
            {
                return false;
            }

            histogram[item]--;
        }
        else
        {
            return false;
        }
    }

    return true;
}

This solution is O(n) if the costs of building the dictionary are negligible while sorting requires O(n*log(n)) time.

Upvotes: 2

LBushkin
LBushkin

Reputation: 131696

Here's some C# code using linq that should do the job, it's basically an implementation of the sort/compare sequence form - which is the most reliable. This code will sort both sequences and compare the for equivalence. You could optimize it slightly, by first checking that myArray and urArray are of the same length, to avoid unnecessary sorting.

char[] myArray = new char[] {'a','b','c','c'};
char[] urArray = new char[] { 'a', 'b', 'c' ,'a'};

var areEqual = myArray.OrderBy( x => x )
                      .SequenceEqual( urArray.OrderBy( x => x ) );

If you can't (or don't want to) use linq for some reason, here is an equivalent version using .NET 2.0 code:

public static bool AreEquivalentArray( char[] a, char[] b )
        {
            if (a.Length != b.Length)
                return false;

            Array.Sort(a);
            Array.Sort(b);
            for (int i = 0; i < a.Length; i++)
            {
                if( !a[i].Equals( b[i] ) )
                    return false;
            }
            return true;
        }

Upvotes: 9

LukeH
LukeH

Reputation: 269398

If you're unable to use LINQ then this should do the trick:

char[] myArray = new char[] { 'a', 'b', 'c', 'c' };
char[] urArray = new char[] { 'a', 'b', 'c' ,'a' };

Console.WriteLine(AreEqual(myArray, urArray));    // False

// ...

public bool AreEqual<T>(IEnumerable<T> first, IEnumerable<T> second)
{
    Dictionary<T, int> map = new Dictionary<T, int>();

    foreach (T item in first)
    {
        if (map.ContainsKey(item))
            map[item]++;
        else
            map[item] = 1;
    }

    foreach (T item in second)
    {
        if (map.ContainsKey(item))
            map[item]--;
        else
            return false;
    }

    foreach (int i in map.Values)
    {
        if (i != 0)
            return false;
    }
    return true;
}

Upvotes: 0

Joe Albahari
Joe Albahari

Reputation: 30934

This is a one-liner with LINQ:

bool same = !array1.Except (array2).Any() && !array2.Except (array1).Any();

Alternatively, you could call OrderBy on each sequence to sort them in the same order and then use Enumerable.SequenceEqual to compare them:

bool same = Enumerable.SequenceEqual (array1.OrderBy (n => n), array2.OrderBy (n => n));

Upvotes: 1

Andriy Volkov
Andriy Volkov

Reputation: 18923

If your arrays only contain unique elements, I would create two HashSets from them and then subtract one from the other to see if the result is the empty set.

Upvotes: 0

David Johnstone
David Johnstone

Reputation: 24450

You could sort the two arrays and then sequentially compare elements. If at any time the two elements being compared are different the arrays contain different elements.

Upvotes: 4

mbillard
mbillard

Reputation: 38842

This seems like the same issue I had: Comparing Two Collections for Equality

Upvotes: 3

Related Questions