CODEWITHSUNDEEP
c#nunitrhino-mocks
AlexC
AlexC

Reputation: 1676

Very simple RhinoMocks test failing - Whats wrong here?

I'm trying to work out why some of my test cases (using RhinoMocks 3.6 Build 20) aren't working, and I've narrowed the issue down to the following minimal unit test:

public interface ITest
{
    string Something { get; }
}

[Test]
public void TestStub()
{
    var mockery = new MockRepository();
    var testItem = mockery.Stub<ITest>();
    testItem.Stub(x => x.Something).Return("Hello");
    Assert.AreEqual("Hello", testItem.Something);
}

This fails with the message:

Expected: "Hello" But was: null

Any ideas what I'm doing wrong here? I've found a few examples on SO and the Rhino Wiki on how to stub read-only properties, and as far as I can tell, this should work fine.

Cheers in advance.

EDIT: Based on sll's advice below, I tried replacing

testItem.Stub(x => x.Something).Return("Hello");

with

testItem.Expect(x => x.Something).Return("Hello");

and the test still fails in the same manner.

Edit 2: I've got this working by adding the line

mockery.ReplayAll();

before the Assert - but I thought this was no longer required (from the wiki: "Mocks/stubs returned from MockRepository.GenerateMock() and MockRepository.GenerateStub() are returned in replay mode, and do not require explicit move to replay mode.")

Upvotes: 1

Views: 825

Answers (3)

AlexC
AlexC

Reputation: 1676

Got it:

From the RhinoMocks 3.6 Blog Post comments:

09/03/2009 05:34 PM by Kurt Harriger

FYI,

I had a few dozen tests fail after upgrading to v 3.6 from code like this:

var mocks = new MockRepository();

var something = mocks.Stub

something.Stub(x=>x.DoSomething() ).Return(true);

something.DoSomething();

The root cause of the problem appears that mock.Stub/Mock/etc no longer returns the mock in replay mode. To fix replaced mock.Stub with MockRepository.GenerateStub.

Ayende Rahien 09/03/2009 06:50 PM by Ayende Rahien

Kurt,

That is actually expected, that should have never worked

So, by changing the test to:

    [Test]
    public void TestStub()
    {
        var testItem = MockRepository.GenerateStub<ITest>();
        testItem.Stub(x => x.Something).Return("Hello");
        Assert.AreEqual("Hello", testItem.Something);
    }

this now works.

Cheers

Upvotes: 1

sll
sll

Reputation: 62504

Try out generating Mock instead:

var testItem = MockRepository.GenerateMock<ITest>();     
testItem.Expect(x => x.Something).Return("Hello");     
Assert.AreEqual("Hello", testItem.Something);

Als make sure you shared entire test method, perhaps you ignored some lines of code? Try out usign Repeat.Any() perhaps proeprty accessed before you are doing expectation.

testItem.Expect(x => x.Something).Return("Hello").Repeat.Any();

On example page Stub() used for methods, and suggested using Mock's Expect() for properties:

Using Expect() to set up properties

The Expect() extention method can be used to set up expectations and return values for properties.

Upvotes: 1

Davin Tryon
Davin Tryon

Reputation: 67296

You are just setting the value so you would expect to do this like this:

public interface ITest
{
    string Something { get; }
}

[Test]
public void TestStub()
{
    var mockery = new MockRepository();
    var testItem = mockery.Stub<ITest>();
    testItem.Something = "Hello";
    Assert.AreEqual("Hello", testItem.Something);
}

No need to Stub with Func.

Upvotes: -1

Related Questions