CODEWITHSUNDEEP
phpsymfonyguzzlesymfony-2.5
EmaOnTheBlock
EmaOnTheBlock

Reputation: 78

How can I make Symfony2 ignore Guzzle Client bad response exception in my custom controller?

   function order_confirmationAction($order,$token) { 

        $client = new \GuzzleHttp\Client();
        $answer  = $client->post("http://www.fullcommerce.com/rest/public/Qtyresponse",
                    array('body' => $order)
        );

        $answer  = json_decode($answer); 

        if ($answer->status=="ACK") {
            return $this->render('AcmeDapiBundle:Orders:ack.html.twig', array(
            'message'   => $answer->message,
        ));
        } else throw new \Symfony\Component\HttpKernel\Exception\HttpException(500, $answer->message);
}

If $client->post() response status code is an "Error 500" Symfony stops the script execution and throw new exception before the json decoding. How can I force Symfony to ignore $client->post() bad response and execute till the last if statement?

Upvotes: 3

Views: 2425

Answers (2)

EmaOnTheBlock
EmaOnTheBlock

Reputation: 78

            $client = new \GuzzleHttp\Client();
            try {
                $answer  = $client->post("http://www.fullcommerce.com/rest/public/Qtyresponse",
                        array('body' => $serialized_order)
                );
            }
            catch (\GuzzleHttp\Exception\ServerException $e) {

                if ($e->hasResponse()) {
                    $m = $e->getResponse()->json();
                    throw new \Symfony\Component\HttpKernel\Exception\HttpException(500, $m['result']['message']);
                }

            }

I solved like this. In that way I can access to responses of remote server even if it returns an error 500 code.

Upvotes: 3

Eric Redon
Eric Redon

Reputation: 1762

Per Guzzle documentation:

Guzzle throws exceptions for errors that occur during a transfer.

Specifically, if the API responds with a 500 HTTP error, you shouldn't expect its content to be JSON, and you don't want to parse it, so you're better off re-throwing an exception from there already (or informing the user that something went wrong). I would suggest trying this out:

function order_confirmationAction($order, $token) { 
    $client = new \GuzzleHttp\Client();
    try {
        $answer  = $client->post("http://www.fullcommerce.com/rest/public/Qtyresponse",
            array('body' => $order)
        );
    }
    catch (Exception $e) {
        throw new \Symfony\Component\HttpKernel\Exception\HttpException(500, $e->getMessage());
    }

    $answer  = json_decode($answer); 

    if ($answer->status=="ACK") {
        return $this->render('AcmeDapiBundle:Orders:ack.html.twig', array(
            'message'   => $answer->message,
        ));
    } else {
        throw new \Symfony\Component\HttpKernel\Exception\HttpException(500, $answer->message);
    }
}

It is probably also a good idea to check for errors when JSON-decoding the response, because there could be surprises in the content you're getting (eg. wrong format, missing or unexpected fields or values, etc.).

Upvotes: 0

Related Questions