CODEWITHSUNDEEP
javascriptjqueryhtml
user2766423
user2766423

Reputation: 167

Dice Game - need to roll more dice based upon circumstances

I am developing a game idea. Weapons can be equipped on your character. Different weapons have different amounts of damage dice and critical hit dice. I have it working currently so that the program rolls the appropriate amount of dice based on your equipped weapon.

However, the program only rolls one critical dice, despite whether the equipped weapon contains two critical roll dies.

var WepEquipped = { "name": "Broken Sword", "attack_dice": "2", "critical_dice": "1", "min_base_dmg": "2", "max_base_dmg": "12", "max_total_dmg": "24", "weapon_type": "Slash" };

function Attack(rolls) {
var total = 0;
var dice = [];

for (var i = 1; i <= rolls; i++) {
    var d6 = Math.floor((Math.random() * 6) + 1);
    $("#dice_container").append("<div class='die_roll'><p class='atk-roll'>" + d6 + "</p></div>");
    dice.push(d6);
    total += d6;
}

// Needs to be able to roll for multiple critical dice
if ($.grep(dice, function (elem) {
    return elem === dice[0];
    }).length == rolls) {
        var d12 = Math.floor((Math.random() * 12) + 1);
        total += d12;
        $("#dice_container").append("<div class='die_roll'><p id='crit-roll'>" + d12 + "</p></div>");
    }
    $("#attack").html("<div>You attack for " + total + "</div>");
};

$('#attack_button').off('click').on('click', function(){
    $('.die_roll').hide();
    Attack(WepEquipped.attack_dice);
    // Attack(WepEquipped.attack_dice);
});

I can explain much more, but I hope this is enough code to grasp what I'm asking. Something here needs to change but I cannot figure out what:

// Needs to be able to roll for multiple critical dice
if ($.grep(dice, function (elem) {
return elem === dice[0];
}).length == rolls) {
    var d12 = Math.floor((Math.random() * 12) + 1);
    total += d12;
    $("#dice_container").append("<div class='die_roll'><p id='crit-roll'>" + d12 + "</p></div>");
}
$("#attack").html("<div>You attack for " + total + "</div>");
};

Upvotes: 0

Views: 127

Answers (1)

serverSentinel
serverSentinel

Reputation: 994

your grep returns the number of elements in the dice array that equal to your first roll and if the length of that array equals the number of rolls that were made you roll the critical dice once.

if ($.grep(dice, function (elem) {
    return elem === dice[0];
    }).length == rolls) {
        var d12 = Math.floor((Math.random() * 12) + 1);
        total += d12;
        $("#dice_container").append("<div class='die_roll'><p id='crit-roll'>" + d12 + "</p></div>");
    }
    $("#attack").html("<div>You attack for " + total + "</div>");
};

If you're trying to roll as many times as the grep returns you need something like this.

var crits = $.grep(dice, function (elem) {return elem === dice[0];});
if( crits.length  == rolls ){
  for( var x=0;x<crits.length;x++){
     var d12 = Math.floor((Math.random() * 12) + 1);
     total += d12;
     $("#dice_container").append("<div class='die_roll'><p id='crit-roll'>" + d12 + "</p></div>");
  }
}

Sorry for the double post, was on an abandoned account.

Upvotes: 1

Related Questions