CODEWITHSUNDEEP
javaregex
regex4html
regex4html

Reputation: 457

Removing every other character in a string using Java regex

I have this homework problem where I need to use regex to remove every other character in a string.

In one part, I have to delete characters at index 1,3,5,... I have done this as follows:

String s = "1a2b3c4d5";
System.out.println(s.replaceAll("(.).", "$1"));

This prints 12345 which is what I want. Essentially I match two characters at a time, and replacing with the first character. I used group capturing to do this.

The problem is, I'm having trouble with the second part of the homework, where I need to delete characters at index 0,2,4,...

I have done the following:

String s = "1a2b3c4d5";
System.out.println(s.replaceAll(".(.)", "$1"));

This prints abcd5, but the correct answer must be abcd. My regex is only incorrect if the input string length is odd. If it's even, then my regex works fine.

I think I'm really close to the answer, but I'm not sure how to fix it.

Upvotes: 10

Views: 10930

Answers (3)

polygenelubricants
polygenelubricants

Reputation: 383746

You are indeed very close to the answer: just make matching the second char optional.

String s = "1a2b3c4d5";
System.out.println(s.replaceAll(".(.)?", "$1"));
// prints "abcd"

This works because:

  • Regex is greedy by default, it will take the second character if it's there
    • When the input is of odd length, the second char won't be there at the last replacement, but you'd still match one char (i.e. last char in input)
  • You can still use backreferences in substitution even if the group fails to match
    • It will substitute in the empty string, not "null"
    • This is different from Matcher.group(int), which returns null for failed groups

References

A closer look at the first part

Let's take a closer look at the first part of the homework:

String s = "1a2b3c4d5";
System.out.println(s.replaceAll("(.).", "$1"));
// prints "12345"

Here you didn't have to use ? for the second char, but it "works" because even though you didn't match the last char, you didn't have to! The last char can remain unmatched, unreplaced, due to the problem specification.

Now suppose that we want to delete chars at index 1,3,5..., and put the chars at index 0,2,4... in brackets.

String s = "1a2b3c4d5";
System.out.println(s.replaceAll("(.).", "($1)"));
// prints "(1)(2)(3)(4)5"

A-ha!! Now you're experiencing the exact same problem with odd-length input! You couldn't match the last char with your regex, because your regex needs two chars, but there's only one char at the end for odd-length input!

The solution, again, is to make matching the second char optional:

String s = "1a2b3c4d5";
System.out.println(s.replaceAll("(.).?", "($1)"));
// prints "(1)(2)(3)(4)(5)"

Upvotes: 20

tim_yates
tim_yates

Reputation: 171084

Your regex needs 2 chars to match, so fails on the final char.

This regex:

".(.{0,1})"

Will make the second char optional, so it will match with your final '5' as well

Upvotes: 0

Matt
Matt

Reputation: 44058

my regex is only incorrect if the input string length is odd. if it's even, then my regex works fine.

Change your expresion to .(.)? - the question mark makes the second character optional, which means it doesn't matter if input is odd or even

Upvotes: 2

Related Questions