CODEWITHSUNDEEP
perforcereview-board
sgarg
sgarg

Reputation: 2459

How to avoid review board interfering with our workflow?

My team is starting to use Review Board with Perforce with a pre-commit review. We want to send all pre-commits to reviewboard. Though I believe pre-commit is the best way to go about this (than a post-commit review), I have some questions:

  1. How does someone verify their changes work with the build system before committing the change? I would want to be confident that the changes I'm submitting for review will build.
  2. Some people like to make small commits. They could be to the same file(s). How do we balance making small commits with submitting each change pre-commit to review board?

Upvotes: 3

Views: 115

Answers (2)

sgarg
sgarg

Reputation: 2459

1) For the first question, if you're using Perforce, one answer is to build shelved changes, like the answer here: https://stackoverflow.com/a/34881362/369243

2) Perforce is not a good solution for making small commits, but git is. There can be multiple small commits in a merge request.

Upvotes: 0

gaganso
gaganso

Reputation: 3011

1) You can have a script that builds the code with your changes on your machine and posts the result of this on the review board in draft state. Based on the result you can publish the review which will notify the reviewer.

2) I agree with @jamesdlin. Your argument that this would slow down the whole process depends on the reviewer.

Upvotes: 1

Related Questions