CODEWITHSUNDEEP
asp.net-mvchttpcontextcontrollers
ozsenegal
ozsenegal

Reputation: 4133

accessing HttpContext.Request in a controller's constructor

I'm following this ASP.NET MVC tutorial from Microsoft:

My code is slightly different, where I'm trying to access HttpContext.Request.IsAuthenticated in the controller's constructor.

namespace SCE.Controllers.Application
{
    public abstract class ApplicationController : Controller
    {
        public ApplicationController()
        {
            bool usuario = HttpContext.Request.IsAuthenticated;
        }           
    }
}

The problem is that HttpContext is always null.

Is there a solution to this?

Upvotes: 70

Views: 52286

Answers (6)

faye.babacar78
faye.babacar78

Reputation: 852

It is possible to get the HttpContext using IHttpContextAccessor injected into class constructor. Before doing so, you will need first to register the corresponding service to the service container in Startup.cs class or Program.cs such as below.

services.AddHttpContextAccessor(); // Startup.cs

builder.Services.AddHttpContextAccessor(); // Program.cs

Right after that, you can inject the IHttpContextAccessor interface in whererever method or class constructor.

 private bool isAuthenticated { get; set; }

    public ConstructorName(IHttpContextAccessor accessor)
    {
        var context = accessor.HttpContext;

        isAuthenticated = context.User.Identity.IsAuthenticated;
    }

Upvotes: 6

Rohil Patel
Rohil Patel

Reputation: 468

enter image description hereWith the answer I am posting here, you cannot access IsAuthenticated, but you can access some stuffs related to HttpContextRequest (see in image),

I needed session value in constructor.

You can use IHttpContextAccessor as below:

public ABCController(IHttpContextAccessor httpContextAccessor)   
{
     //do you stuff with httpContextAccessor,  

     // This gives session value
     string abc = httpContextAccessor.HttpContext.Session.GetString("Abc");
}

and in startup.cs, you need to configure,

services.AddHttpContextAccessor();

Upvotes: 5

rob waminal
rob waminal

Reputation: 18419

instead of putting your HttpContext.Request.IsAuthenticated in Controller level you should put it in Controller Base class that will be inherited in all of your controller with an override method of OnActionExecuting() method.

In your Controller base you should have

public class BaseController : Controller
{
    protected override void OnActionExecuting(ActionExecutingContext ctx) {
        base.OnActionExecuting(ctx);
        ViewData["IsAuthenticated"] = HttpContext.Request.IsAuthenticated;
    }
}

and all your Controller should inherit the BaseController class

public class ApplicationController : BaseController

now you should get the ViewData["IsAuthenticated"] in your Master page.

Edit

With the link you have given, and relating to what you have done, your ApplicationController is a Page Controller, not a Base Controller. In the example, ApplicationController is a Base Controller that is inherited by the HomeController but what you have done is you are placing the Action method inside your base controller which is the ApplicationController so your Action Index method will not be invoked when you call any page (Index page) that is not from the ApplicationController.

Upvotes: 116

Ricardo Rodriguez
Ricardo Rodriguez

Reputation: 421

The solution of this problem is to create an override method of Initialize by passing RequestContext object.

public class ChartsController : Controller
{
     bool isAuthed = false;
    protected override void Initialize(System.Web.Routing.RequestContext requestContext)
    {
        base.Initialize(requestContext);

        if (requestContext.HttpContext.User.Identity.IsAuthenticated)
        {
          isAuthed =true;
        }
    }
}

Upvotes: 11

spender
spender

Reputation: 120380

The Controller is instantiated significantly prior to the point where the Index action is invoked, and at the moment of construction HttpContext is indeed unavailable. What's wrong with referencing it in your controller method Index?

Upvotes: 13

Ghini Antonio
Ghini Antonio

Reputation: 3122

I would suggest you use:

 System.Web.HttpContext.Current.Request

Just remember System.Web.HttpContext.Current is threadstatic, but if you don't use additional thread the solution works.

Upvotes: 60

Related Questions