Seppo Kuusela
Seppo Kuusela

Reputation: 59

PHP Code takes only one row from MySQL

I have made a little website and i want that it shows every users who have registered in Admin Panel. Problem is that it only shows one user even if 5 people have registered.

PHP:

<?php $query = mysql_query("SELECT * FROM users ORDER BY id DESC");

while ($rows = mysql_fetch_array($query)) {
$steamid = $rows['steamid'];
$tlink = $rows['tlink'];
$email = $rows['email'];
$twitter = $rows['twitter'];
$admin = $rows['admin'];
$name = $rows['name'];
$rank = $rows['rank'];
$avatar = $rows['avatar'];
$ban = $rows['ban'];
}

echo '<img src="'.$avatar.'"> <br> '.$name.' <br> '.$tlink.' ';

?>

So how i can make it that it takes every user not only one user?

Upvotes: 0

Views: 42

Answers (1)

Jay Blanchard
Jay Blanchard

Reputation: 34426

The echo needs to be inside the loop:

<?php 

$query = mysql_query("SELECT * FROM users ORDER BY id DESC");

while ($rows = mysql_fetch_array($query)) {
    $steamid = $rows['steamid'];
    $tlink = $rows['tlink'];
    $email = $rows['email'];
    $twitter = $rows['twitter'];
    $admin = $rows['admin'];
    $name = $rows['name'];
    $rank = $rows['rank'];
    $avatar = $rows['avatar'];
    $ban = $rows['ban'];

    echo '<img src="'.$avatar.'"> <br> '.$name.' <br> '.$tlink.' ';
}

?>

Please stop using mysql_* functions. These extensions have been removed in PHP 7. Learn about prepared statements for PDO and MySQLi and consider using PDO, it's really pretty easy.

Upvotes: 1

Related Questions