CODEWITHSUNDEEP
pythondjangodjango-urls
glss
glss

Reputation: 345

Django: request.GET and KeyError

Code:

# it's an ajax request, so parameters are passed via GET method
def my_view(request):
    my_param = request.GET['param'] // should I check for KeyError exception?

In PHP Frameworks I typically have to check for parameter to exists and redirect user somewhere if it does not. But in Django unexisted parameter results in 500 error page and it seems desired behaviour. So is it ok to leave code as is or there is a better practic? Should I always use standard params passing like /myaction/paramvalue/ instead of /myaction?param_name=param_value (it's kinda hard to build such URLs for ajax requests)?

Upvotes: 31

Views: 29735

Answers (3)

Srikanth Chundi
Srikanth Chundi

Reputation: 917

How about passing default value if param doesn't exist ?

my_param = request.GET.get('param', 'defaultvalue')

Upvotes: 1

Ned Batchelder
Ned Batchelder

Reputation: 375744

Your server should never produce a 500 error page.

You can avoid the error by using:

my_param = request.GET.get('param', default_value)

or:

my_param = request.GET.get('param')
if my_param is None:
    return HttpResponseBadRequest()

Upvotes: 61

Mike DeSimone
Mike DeSimone

Reputation: 42825

Yes, you should check for KeyError in that case. Or you could do this:

if 'param' in request.GET:
    my_param = request.GET['param']
else:
    my_param = default_value

Upvotes: 12

Related Questions