CODEWITHSUNDEEP
jenkinsgerritlabel
clever_bassi
clever_bassi

Reputation: 2480

Gerrit - same patchset multiple verified labels

I am working on a project that has gerrit-jenkins trigger set up. I uploaded a patchset and the jenkins job was not completely correct thus the job failed and posted a -1 Verified label on the gerrit patchset.

Thereafter, I submitted a +1 verified label manually. My question is, if the same patchset has multiple verified labels (-1 and +1), does it allow to submit the change if the last label is +1 (even if its manually and not via jenkins).

I cannot test this change on the project I'm working on because of permission issues and the official documentation doesn't say anything about precedence of multiple verified labels.

Upvotes: 0

Views: 570

Answers (1)

Marcelo Ávila de Oliveira
Marcelo Ávila de Oliveira

Reputation: 22411

Unless someone has changed the default Verified label configuration, the -1 vote will block the submit even if the +1 vote exists.

[label "Verified"]
      function = MaxWithBlock
      value = -1 Fails
      value =  0 No score
      value = +1 Verified

The function = MaxWithBlock means:

The lowest possible negative value, if present, blocks a submit, while the highest possible positive value is required to enable submit. There must be at least one positive value, or else submit will never be enabled. To permit blocking submits, ensure a negative value is defined.

More info here.

Upvotes: 1

Related Questions