CODEWITHSUNDEEP
jenkinsgerrit
Boris Brodski
Boris Brodski

Reputation: 8715

Upload patch set preserving existing reviews

We use Jenkins to verify patch sets. Sometimes Jenkins needs do some changes on the patch set. So it commit --amend the changes and then uploads the new patch set.

It work nicely besides the fact, that all manual reviews made to the original patch set get erased.

Upvotes: 1

Views: 291

Answers (1)

Marcelo Ávila de Oliveira
Marcelo Ávila de Oliveira

Reputation: 22411

Be aware that, in the situation you have described, you have a new patchset and, excluding in special situations, you don't want votes of the old patchset copied forward to the new patchset. For example: if someone have approved the patchset1 and Jenkins pushes the patchset2, probably he/she doesn't want to have his/her vote automatically copied to patchset2.

Said that: you can control how votes will/won't be copied forward to new patchset setting the label.LABEL-NAME.copyXXXXX options of the project. See more info in Gerrit documentation here.

Upvotes: 2

Related Questions