CODEWITHSUNDEEP
pythonexceptiontry-except
nitin_cherian
nitin_cherian

Reputation: 6655

Pythonic way to try reading a file and in case of exception fallback to alternate file

What is the Pythonic way to try reading a file and if this read throws an exception fallback to read an alternate file?

This is the sample code I wrote, which uses nested try-except blocks. Is this pythonic:

try:
    with open(file1, "r") as f:
        params = json.load(f)
except IOError:
    try:
        with open(file2, "r") as f:
            params = json.load(f)
    except Exception as exc:
        print("Error reading config file {}: {}".format(file2, str(exc)))
        params = {}
except Exception as exc:
    print("Error reading config file {}: {}".format(file1, str(exc)))
    params = {}

Upvotes: 1

Views: 633

Answers (4)

gavinest
gavinest

Reputation: 348

I recommend using pathlib.Path for this.

from pathlib import Path

path1 = Path(file1)
path2 = Path(file2)

path = path1 if path1.exists() else path2

with path.open('r') as f:
   params = json.load(f)

You can add additional error checking on whether path2 exists or not if desired.

Upvotes: 0

MSeifert
MSeifert

Reputation: 152657

For two files the approach is in my opinion good enough.

If you had more files to fallback I would go with a loop:

for filename in (file1, file2):
    try:
        with open(filename, "r") as fin:
            params = json.load(f)
        break
    except IOError:
        pass
    except Exception as exc:
        print("Error reading config file {}: {}".format(filename, str(exc)))
        params = {}
        break
else:   # else is executed if the loop wasn't terminated by break
    print("Couldn't open any file")
    params = {}

Upvotes: 1

Wiggy A.
Wiggy A.

Reputation: 496

Although I'm not exactly certain whether this is pythonic or not, perhaps something like:

file_to_open = file1 if os.path.isfile(file1) else file2

Upvotes: 0

Chen A.
Chen A.

Reputation: 11280

You can check if file1 exists first, and then decide which file to open. It will shorten the code and avoid repeating the try -- catch clause. I believe it is more pythonic, however note that you need to import os in your module for this to work. It can be something like:

fp = file1 if os.path.isfile(file1) else file2
if os.path.isfile(fp):
    try:
        with open(fp, "r") as f:
            params = json.load(f)
    except Exception as exc:
        print("Error reading config file {}: {}".format(fp, str(exc)))
            params = {}
else:
    print 'no config file'

Upvotes: 0

Related Questions