CODEWITHSUNDEEP
c++operator-overloadingreturn-by-reference
NoSenseEtAl
NoSenseEtAl

Reputation: 30026

Should overloaded operator = be returning class& or class

while googling for how to overload operator = I found that some examples return value http://www.cprogramming.com/tutorial/operator_overloading.html
, while a friend of mine that is C++ guru long time ago told me to return reference. Also for example when I look at the STL source I saw stuff like:

  vector&
  operator=(const vector& __x);

so what is the correct way to do it ?

BTW if you are curious my friend told me that the reason why to return ref is beause built in types return l-value.

int x;
(x = 3) += 2;
// x is now 5.

Upvotes: 1

Views: 684

Answers (3)

ken
ken

Reputation: 836

Its always good to use the reference as both memory and time are saved.if you pass by value new object has to be created copy constructor will have to be called.which is more expensive with respect to time as well as memory.

so pass it by reference always unless you have a very strong necessity to be passed/returned by value.

Upvotes: 1

user1084944
user1084944

Reputation:

Other than special cases where you really, really know what you're doing, it should return either class& or void. (And most of the time, returning void should just be a placeholder for "I'm being lazy and haven't gotten around to making sure that returning class& makes sense")

Returning class is a bad idea because it wastes time and memory (it makes a copy!) in the normal case where the user doesn't use the return value, and will thoroughly mislead a user who actually does use the return value (and still waste time making copies).

Upvotes: 5

CashCow
CashCow

Reputation: 31435

Yes, it should return a reference-to-self.

Upvotes: 3

Related Questions